vmware_host_firewall_manager: Remove deprecated functionality #1463

mariolenz · 2022-09-18T12:57:18Z

SUMMARY

Fixes #1197

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

vmware_host_firewall_manager

ADDITIONAL INFORMATION

community.vmware/plugins/modules/vmware_host_firewall_manager.py

Lines 387 to 395 in ce764aa

    
           if isinstance(rule_option['allowed_hosts'], list): 
        
               if len(rule_option['allowed_hosts']) == 1: 
        
                   allowed_hosts = rule_option['allowed_hosts'][0] 
        
                   rule_option['allowed_hosts'] = allowed_hosts 
        
                   module.deprecate( 
        
                       msg='allowed_hosts should be a dict, not a list', 
        
                       version='3.0.0', 
        
                       collection_name='community.vmware' 
        
                   )

and

community.vmware/plugins/modules/vmware_host_firewall_manager.py

Lines 398 to 406 in ce764aa

    
           try: 
        
               isinstance(rule_option["allowed_hosts"]["all_ip"], bool) 
        
           except (KeyError, IndexError): 
        
               module.deprecate( 
        
                   msg=('Please adjust your playbook to ensure the `allowed_hosts` ' 
        
                        'entries come with an `all_ip` key (boolean).'), 
        
                   version='3.0.0', 
        
                   collection_name='community.vmware' 
        
               )

softwarefactory-project-zuul · 2022-09-18T13:01:46Z

Build failed.

❌ ansible-tox-linters FAILURE in 3m 59s
❌ build-ansible-collection FAILURE in 3m 30s
⚠️ ansible-test-sanity-docker-devel SKIPPED (non-voting)
⚠️ ansible-test-sanity-docker-milestone SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.12 SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.13 SKIPPED
⚠️ ansible-test-units-community-vmware-python38 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED
⚠️ ansible-galaxy-importer SKIPPED

softwarefactory-project-zuul · 2022-09-18T18:34:48Z

Build failed.

softwarefactory-project-zuul · 2022-09-19T07:33:28Z

Build failed.

softwarefactory-project-zuul · 2022-09-19T19:14:16Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 4m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 37s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 35s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 13s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 45s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 30s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 40s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 16m 02s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 RETRY_LIMIT in 1h 02m 28s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 RETRY_LIMIT in 1h 02m 54s
✔️ ansible-galaxy-importer SUCCESS in 4m 47s

softwarefactory-project-zuul · 2022-09-20T07:04:35Z

Build failed.

softwarefactory-project-zuul · 2022-09-20T12:30:50Z

Build succeeded.

softwarefactory-project-zuul · 2022-09-20T16:18:51Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 4m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 29s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 29s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 40s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 53s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 18s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 52m 29s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 17m 41s
✔️ ansible-galaxy-importer SUCCESS in 3m 37s

mariolenz · 2022-09-20T16:22:18Z

recheck

softwarefactory-project-zuul · 2022-09-20T18:32:13Z

Build succeeded.

softwarefactory-project-zuul · 2022-09-20T18:47:41Z

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 3m 37s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 56s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 34s
✔️ ansible-galaxy-importer SUCCESS in 4m 18s

Update changelog fragments for a better porting guide SUMMARY Update changelog fragments for a better porting guide ISSUE TYPE Docs Pull Request COMPONENT NAME vsphere_copy vmware_dns_config vmware_dvs_portgroup vmware_guest_boot_manager vmware_guest_network vmware_guest_vnc vmware_host_firewall_manager ADDITIONAL INFORMATION #1456 #1455 #1483 #1461 #1459 #1454 #1463

mariolenz added the WIP Work in progress label Sep 18, 2022

mariolenz force-pushed the issue1197 branch 2 times, most recently from fadd1d7 to 6481ac7 Compare September 18, 2022 13:35

mariolenz changed the title ~~[WIP] vmware_host_firewall_manager: Improve argument_spec~~ [WIP] vmware_host_firewall_manager: Remove deprecated functionality Sep 18, 2022

mariolenz force-pushed the issue1197 branch from 6481ac7 to 0d84229 Compare September 18, 2022 15:22

vmware_host_firewall_manager: Improve argument_spec

5780daf

mariolenz force-pushed the issue1197 branch from 0d84229 to 5780daf Compare September 18, 2022 16:01

Use FQCN in integration tests

fc42ad8

mariolenz force-pushed the issue1197 branch from ca0ae4e to 29fa050 Compare September 19, 2022 14:06

mariolenz added 2 commits September 19, 2022 16:38

Improve integration tests readability

6c70a35

Fix disable vvold integration test

6e77204

mariolenz force-pushed the issue1197 branch from 29fa050 to 6e77204 Compare September 19, 2022 14:51

Improve integration tests

471ed5d

mariolenz force-pushed the issue1197 branch from cf08bb2 to 471ed5d Compare September 19, 2022 16:47

Fix firewall cleanup in integration tests

a39f69a

Fix indentation errors

3d2e344

mariolenz force-pushed the issue1197 branch from 810ee2d to 3d2e344 Compare September 20, 2022 10:31

Define requirements in arg spec

3964301

mariolenz closed this Sep 20, 2022

mariolenz reopened this Sep 20, 2022

Add changelog fragment

d7b6a53

mariolenz changed the title ~~[WIP] vmware_host_firewall_manager: Remove deprecated functionality~~ vmware_host_firewall_manager: Remove deprecated functionality Sep 20, 2022

mariolenz added mergeit and removed WIP Work in progress labels Sep 20, 2022

softwarefactory-project-zuul bot merged commit fac9919 into ansible-collections:main Sep 20, 2022

mariolenz deleted the issue1197 branch September 20, 2022 18:48

mariolenz mentioned this pull request Oct 9, 2022

Update changelog fragments for a better porting guide #1490

Merged

renovate bot mentioned this pull request Oct 10, 2022

Update dependency community.vmware to v3 - autoclosed Fredouye/argocd#11

Closed

1 task

slauger mentioned this pull request Oct 11, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#60

Closed

1 task

slauger mentioned this pull request Oct 24, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#68

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vmware_host_firewall_manager: Remove deprecated functionality #1463

vmware_host_firewall_manager: Remove deprecated functionality #1463

mariolenz commented Sep 18, 2022

softwarefactory-project-zuul bot commented Sep 18, 2022

softwarefactory-project-zuul bot commented Sep 18, 2022

softwarefactory-project-zuul bot commented Sep 19, 2022

softwarefactory-project-zuul bot commented Sep 19, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

mariolenz commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

	if isinstance(rule_option['allowed_hosts'], list):
	if len(rule_option['allowed_hosts']) == 1:
	allowed_hosts = rule_option['allowed_hosts'][0]
	rule_option['allowed_hosts'] = allowed_hosts
	module.deprecate(
	msg='allowed_hosts should be a dict, not a list',
	version='3.0.0',
	collection_name='community.vmware'
	)

	try:
	isinstance(rule_option["allowed_hosts"]["all_ip"], bool)
	except (KeyError, IndexError):
	module.deprecate(
	msg=('Please adjust your playbook to ensure the `allowed_hosts` '
	'entries come with an `all_ip` key (boolean).'),
	version='3.0.0',
	collection_name='community.vmware'
	)

vmware_host_firewall_manager: Remove deprecated functionality #1463

vmware_host_firewall_manager: Remove deprecated functionality #1463

Conversation

mariolenz commented Sep 18, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Sep 18, 2022

softwarefactory-project-zuul bot commented Sep 18, 2022

softwarefactory-project-zuul bot commented Sep 19, 2022

softwarefactory-project-zuul bot commented Sep 19, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

mariolenz commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022